RE: [PATCH iproute2-next 2/2] f_flower: Implement gtp options support

Hi Stephen,

I was just following the approach used for other options but it looks like that
JSON specific code is not needed. I 'll get rid of it in next version.

Regards,
Wojtek

-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Sent: czwartek, 27 stycznia 2022 18:16
To: Drewek, Wojciech <redacted>
Cc: netdev@vger.kernel.org; dsahern@gmail.com; michal.swiatkowski@linux.intel.com; marcin.szycik@linux.intel.com
Subject: Re: [PATCH iproute2-next 2/2] f_flower: Implement gtp options support

On Thu, 27 Jan 2022 14:13:55 +0100
Wojciech Drewek [off-list ref] wrote:

quoted

+	open_json_array(PRINT_JSON, name);
+	open_json_object(NULL);
+	print_uint(PRINT_JSON, "pdu_type", NULL, pdu_type);
+	print_uint(PRINT_JSON, "qfi", NULL, qfi);
+	close_json_object();
+	close_json_array(PRINT_JSON, name);
+
+	sprintf(strbuf, "%02x:%02x", pdu_type, qfi);

Doing JSON specific code is not necessary here?
And why an array of two named elements? Seems confusing