Re: [PATCH net-next 11/13] netlink: add net device refcount tracker to struct ethnl_req_info

On Tue, 04 Jan 2022 17:23:51 +0100 Johannes Berg wrote:

quoted

diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
index ea23659fab28..5fe8f4ae2ceb 100644
--- a/net/ethtool/netlink.c
+++ b/net/ethtool/netlink.c

@@ -627,7 +627,6 @@ static void ethnl_default_notify(struct net_device

*dev, unsigned int cmd,
        }

        req_info->dev = dev;
-       netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);  

So I had already tested both this and explicitly doing
netdev_tracker_free() when req_info is freed, both work fine.

Tested-by: Johannes Berg <johannes@sipsolutions.net>

Just wasn't sure it was correct or I was missing something. :)

Hi Eric, I didn't see this one submitted, is it coming?
No rush, just checking if it fell thru the cracks.