Re: [PATCH net-next 11/13] netlink: add net device refcount tracker to struct ethnl_req_info
flat view
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2022-01-04 15:29:30
On Mon, 2021-12-06 at 17:30 -0800, Eric Dumazet wrote:
quoted hunk ↗ jump to hunk
@@ -624,6 +625,7 @@ static void ethnl_default_notify(struct net_device *dev, unsigned int cmd, } req_info->dev = dev; + netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL); req_info->flags |= ETHTOOL_FLAG_COMPACT_BITSETS;
I may have missed a follow-up patch (did a search on netdev now, but ...), but I'm hitting warnings from this and I'm not sure it's right? This req_info is just allocated briefly and freed again, and I'm not even sure there's a dev_get/dev_put involved here, I didn't see any? At least it would seem we need to free the tracker at the end of this function, or perhaps never even create one? johannes