RE: [PATCH net-next 2/2] net: stmmac: add tc flower filter for EtherType matching
From: Ong, Boon Leong <hidden>
Date: 2021-12-11 14:04:37
Also in:
linux-arm-kernel
quoted hunk ↗ jump to hunk
[snip]quoted
+ if (match.mask->n_proto) { + __be16 etype = ntohs(match.key->n_proto);n_proto is be16. The ntohs() call will produce an u16. Delta patch below. Thanks, Kurtdiff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.hb/drivers/net/ethernet/stmicro/stmmac/stmmac.h index 35ff7c835018..d64e42308eb6 100644--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h@@ -182,7 +182,7 @@ enum stmmac_rfs_type {struct stmmac_rfs_entry { unsigned long cookie; - __be16 etype; + u16 etype; int in_use; int type; int idx;diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.cb/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index cb7400943bb0..afa918185cf7 100644--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c@@ -759,7 +759,7 @@ static int tc_add_ethtype_flow(struct stmmac_priv*priv, flow_rule_match_basic(rule, &match); if (match.mask->n_proto) { - __be16 etype = ntohs(match.key->n_proto); + u16 etype = ntohs(match.key->n_proto); if (match.mask->n_proto != ETHER_TYPE_FULL_MASK) { netdev_err(priv->dev, "Only full mask is supported for EthType filter");
Thanks for the suggestion. I will incorporate in v2 patch after we conclude if the tc flower hw_tc interface used for specifying RxQ queue is agreeable by community.