Re: [PATCH v20 bpf-next 23/23] xdp: disable XDP_REDIRECT for xdp multi-buff
From: Jesper Dangaard Brouer <hidden>
Date: 2021-12-11 06:50:05
Also in:
bpf
On 10/12/2021 20.14, Lorenzo Bianconi wrote:
XDP_REDIRECT is not fully supported yet for xdp multi-buff since not all XDP capable drivers can map non-linear xdp_frame in ndo_xdp_xmit so disable it for the moment. Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> ---
LGTM you addressed my last review comments. Acked-by: Jesper Dangaard Brouer <redacted> I do expect followup patches that add support for ndo_xdp_xmit in drivers...
quoted hunk ↗ jump to hunk
net/core/filter.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/net/core/filter.c b/net/core/filter.c index 14860931733d..def6e9f451a7 100644 --- a/net/core/filter.c +++ b/net/core/filter.c@@ -4186,6 +4186,13 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, struct bpf_map *map; int err; + /* XDP_REDIRECT is not fully supported yet for xdp multi-buff since + * not all XDP capable drivers can map non-linear xdp_frame in + * ndo_xdp_xmit. + */ + if (unlikely(xdp_buff_is_mb(xdp) && map_type != BPF_MAP_TYPE_CPUMAP)) + return -EOPNOTSUPP; + ri->map_id = 0; /* Valid map id idr range: [1,INT_MAX[ */ ri->map_type = BPF_MAP_TYPE_UNSPEC;