Re: [net 01/11] net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init_resources
flat view
From: Saeed Mahameed <saeed@kernel.org>
Date: 2021-12-23 04:28:21
On Wed, 2021-12-22 at 17:09 -0800, Jakub Kicinski wrote:
On Wed, 22 Dec 2021 17:04:03 -0800 Jakub Kicinski wrote:quoted
On Wed, 22 Dec 2021 13:11:51 -0800 Saeed Mahameed wrote:quoted
From: Miaoqian Lin <redacted> The mlx5_get_uars_page() function returns error pointers. Using IS_ERR() to check the return value to fix this. Fixes: 4ec9e7b02697("net/mlx5: DR, Expose steering domain functionality")Do you mind fixing this missing space? I'll cherry pick the change from
Sure, I will submit v2.
quoted
net-next in the meantime.I take that back, I thought the error was on our side but looks like the patch was put in the wrong PR. Why not put it in the net PR
Yes, my mistake, the bug only existed in net-next when I accepted the patch, I mistakenly left it in my net-next tree after rc1 was out.
yourself? We'll handle the unavoidable conflict, but I don't see any advantage to me cherry picking here (which I can't do directly anyway,
This how I remember we used to do it. Sure i will attach it in v2. I already checked, there will be no conflicts.