Re: [PATCH net 7/7] ice: safer stats processing

On 12/7/2021 9:58 PM, Jakub Kicinski wrote:

quoted

@@ -6219,6 +6227,7 @@ void ice_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
  	 */
  	if (!test_bit(ICE_VSI_DOWN, vsi->state))
  		ice_update_vsi_ring_stats(vsi);
+
  	stats->tx_packets = vsi_stats->tx_packets;
  	stats->tx_bytes = vsi_stats->tx_bytes;
  	stats->rx_packets = vsi_stats->rx_packets;

🙄 in a fix that has to go back to 4.16?

Whoops! Yeah, that was my bad. Looks like I owe Tony a beer, he already fixed it and sent a v2. Normally I'd mention whitespace changes like that in the commit message and not include those in a "Fixes" patch, but this one slipped through when I created it. Thanks for the review!