Thread (10 messages) 10 messages, 3 authors, 2021-12-08

Re: [PATCH net 7/7] ice: safer stats processing

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-12-08 05:58:59

On Tue,  7 Dec 2021 14:25:44 -0800 Tony Nguyen wrote:
quoted hunk ↗ jump to hunk
@@ -5949,6 +5950,7 @@ ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,
 			ice_fetch_u64_stats_per_ring(&ring->syncp, ring->stats, &pkts, &bytes);
 		vsi_stats->tx_packets += pkts;
 		vsi_stats->tx_bytes += bytes;
+
 		vsi->tx_restart += ring->tx_stats.restart_q;
 		vsi->tx_busy += ring->tx_stats.tx_busy;
 		vsi->tx_linearize += ring->tx_stats.tx_linearize;
quoted hunk ↗ jump to hunk
@@ -6219,6 +6227,7 @@ void ice_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
 	 */
 	if (!test_bit(ICE_VSI_DOWN, vsi->state))
 		ice_update_vsi_ring_stats(vsi);
+
 	stats->tx_packets = vsi_stats->tx_packets;
 	stats->tx_bytes = vsi_stats->tx_bytes;
 	stats->rx_packets = vsi_stats->rx_packets;
🙄 in a fix that has to go back to 4.16?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help