Thread (3 messages) 3 messages, 3 authors, 2021-12-10

Re: [PATCH net-next] net: x25: drop harmless check of !more

flat view

From: Martin Schiller <ms@dev.tdt.de>
Date: 2021-12-08 08:11:14

On 2021-12-08 08:20, Jεan Sacren wrote:
quoted hunk ↗ jump to hunk
From: Jean Sacren <redacted>

'more' is checked first.  When !more is checked immediately after that,
it is always true.  We should drop this check.

Signed-off-by: Jean Sacren <redacted>
---
 net/x25/x25_in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/x25/x25_in.c b/net/x25/x25_in.c
index e1c4197af468..b981a4828d08 100644
--- a/net/x25/x25_in.c
+++ b/net/x25/x25_in.c
@@ -41,7 +41,7 @@ static int x25_queue_rx_frame(struct sock *sk,
struct sk_buff *skb, int more)
 		return 0;
 	}

-	if (!more && x25->fraglen > 0) {	/* End of fragment */
+	if (x25->fraglen > 0) {	/* End of fragment */
 		int len = x25->fraglen + skb->len;

 		if ((skbn = alloc_skb(len, GFP_ATOMIC)) == NULL){
Acked-by: Martin Schiller <ms@dev.tdt.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help