From: Jean Sacren <redacted>
'more' is checked first. When !more is checked immediately after that,
it is always true. We should drop this check.
Signed-off-by: Jean Sacren <redacted>
---
net/x25/x25_in.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -41,7 +41,7 @@ static int x25_queue_rx_frame(struct sock *sk, struct sk_buff *skb, int more)return0;}-if(!more&&x25->fraglen>0){/* End of fragment */+if(x25->fraglen>0){/* End of fragment */intlen=x25->fraglen+skb->len;if((skbn=alloc_skb(len,GFP_ATOMIC))==NULL){
From: Martin Schiller <ms@dev.tdt.de> Date: 2021-12-08 08:11:14
On 2021-12-08 08:20, Jεan Sacren wrote:
quoted hunk
From: Jean Sacren <redacted>
'more' is checked first. When !more is checked immediately after that,
it is always true. We should drop this check.
Signed-off-by: Jean Sacren <redacted>
---
net/x25/x25_in.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -41,7 +41,7 @@ static int x25_queue_rx_frame(struct sock *sk,
struct sk_buff *skb, int more)
return 0;
}
- if (!more && x25->fraglen > 0) { /* End of fragment */
+ if (x25->fraglen > 0) { /* End of fragment */
int len = x25->fraglen + skb->len;
if ((skbn = alloc_skb(len, GFP_ATOMIC)) == NULL){
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:
On Wed, 8 Dec 2021 00:20:25 -0700 you wrote:
From: Jean Sacren <redacted>
'more' is checked first. When !more is checked immediately after that,
it is always true. We should drop this check.
Signed-off-by: Jean Sacren <redacted>
[...]