Re: [PATCH net] net: dsa: mv88e6xxx: fix "don't use PHY_DETECT on internal PHY's"

On Tue, Dec 07, 2021 at 02:22:56PM +0100, Maarten Zanders wrote:

On 12/7/21 11:32, Russell King (Oracle) wrote:

quoted

Maarten Zanders has confirmed that the issue he was addressing was for
an 88E6250 switch, which does not have a PHY_DETECT bit in bit 12, but
instead a link status bit. Therefore, mv88e6xxx_port_ppu_updates() does
not report correctly.

...>    Yes, you're right, I'm targeting the 6250 family. And yes, your

quoted

   suggestion would solve my case and is a better implementation for
   the other devices (as far as I can see).

I confirm that this patch works on my hardware, which uses an 88E6071
(88E6250 family).

Thanks for testing! Would you be able to supply a Tested-by:
attributation for the patch, so your confirmation can be recorded in
the commit please?

Thanks again.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!