Re: [PATCH RESEND net-next 5/5] net: wwan: core: make debugfs optional
From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Date: 2021-12-02 22:42:16
On Thu, Dec 2, 2021 at 3:03 PM Leon Romanovsky [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On Thu, Dec 02, 2021 at 01:03:33AM +0300, Sergey Ryazanov wrote:quoted
Ironically, I took your "don't over-engineer" argument and started removing the IOSM specific configuration option when I realized that the IOSM debugfs interface depends on relayfs and so it should select the RELAY option. Without the IOSM debugfs option, we should either place RELAY selection to an option that enables the driver itself, or to the WWAN subsystem debugfs enabling option. The former will cause the kernel inflation even with the WWAN debugfs interface disabled. The latter will simply be misleading. In the end, I decided to keep both config options in the V2.Something like this will do the trick.diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig index bdb2b0e46c12..ebb7292421a1 100644 --- a/drivers/net/wwan/Kconfig +++ b/drivers/net/wwan/Kconfig@@ -85,6 +85,7 @@ config IOSM tristate "IOSM Driver for Intel M.2 WWAN Device" depends on INTEL_IOMMU select NET_DEVLINK + select RELAY if WWAN_DEBUGFS help This driver enables Intel M.2 WWAN Device communication.
Yes! This is exactly what I need to finally solve this puzzle. Thank you! -- Sergey