Re: [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()
From: Cai Huoqing <hidden>
Date: 2021-11-05 03:15:19
Also in:
lkml
On 05 11月 21 01:42:17, Xu Wang wrote:
The print function dev_err() is redundant because platform_get_irq() already prints an error.
Reviewed-by: Cai Huoqing <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Xu Wang <redacted> --- drivers/net/ethernet/litex/litex_liteeth.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c index 3d9385a4989b..ab9fa1525053 100644 --- a/drivers/net/ethernet/litex/litex_liteeth.c +++ b/drivers/net/ethernet/litex/litex_liteeth.c@@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev) priv->dev = &pdev->dev; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq); + if (irq < 0) return irq; - } netdev->irq = irq; priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");-- 2.25.1