[PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()

Subsystems: litex platform, networking drivers, the rest

STALE1741d

3 messages, 3 authors, 2021-11-05 · open the first message on its own page

[PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()

From: Xu Wang <hidden>
Date: 2021-11-05 01:42:42

The print function dev_err() is redundant because
platform_get_irq() already prints an error.

Signed-off-by: Xu Wang <redacted>
---
 drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
index 3d9385a4989b..ab9fa1525053 100644
--- a/drivers/net/ethernet/litex/litex_liteeth.c
+++ b/drivers/net/ethernet/litex/litex_liteeth.c
@@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev)
 	priv->dev = &pdev->dev;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 	netdev->irq = irq;
 
 	priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
-- 
2.25.1

Re: [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()

From: Cai Huoqing <hidden>
Date: 2021-11-05 03:15:19

On 05 11月 21 01:42:17, Xu Wang wrote:
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Reviewed-by: Cai Huoqing <redacted>
quoted hunk
Signed-off-by: Xu Wang <redacted>
---
 drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
index 3d9385a4989b..ab9fa1525053 100644
--- a/drivers/net/ethernet/litex/litex_liteeth.c
+++ b/drivers/net/ethernet/litex/litex_liteeth.c
@@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev)
 	priv->dev = &pdev->dev;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 	netdev->irq = irq;
 
 	priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
-- 
2.25.1

Re: [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-11-05 10:20:12

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Fri,  5 Nov 2021 01:42:17 +0000 you wrote:
The print function dev_err() is redundant because
platform_get_irq() already prints an error.

Signed-off-by: Xu Wang <redacted>
---
 drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Here is the summary with links:
  - net: ethernet: litex: Remove unnecessary print function dev_err()
    https://git.kernel.org/netdev/net/c/827beb7781d3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help