Re: [PATCH iproute2] ip route: save: exclude rtnh_flags which can't be set
flat view
From: Ido Schimmel <hidden>
Date: 2021-11-28 13:11:46
On Fri, Nov 26, 2021 at 04:43:10PM +0300, Alexander Mikhalitsyn wrote:
quoted hunk ↗ jump to hunk
+ /* + * Exclude flags which can't be set directly + * by the userspace from the rtmsg dump. + */
I believe iproute2 is following netdev style comments [1] so this should be: /* Exclude flags which can't be set directly * by the userspace from the rtmsg dump. */ At least it's consistent with other comments in the file. [1] https://www.kernel.org/doc/html/v5.12/networking/netdev-FAQ.html#is-the-comment-style-convention-different-for-the-networking-content
+ r->rtm_flags &= ~RTNH_REJECT_MASK;
+
ret = write(STDOUT_FILENO, n, n->nlmsg_len);
if ((ret > 0) && (ret != n->nlmsg_len)) {
fprintf(stderr, "Short write while saving nlmsg\n");
--
2.31.1