Re: [RFC PATCH net-next] rtnetlink: add RTNH_F_REJECT_MASK

Dear Jakub,

Thanks for your attention to the patch. Sure, I will do it.

Please, let me know, what do you think about RTNH_F_OFFLOAD,
RTNH_F_TRAP flags? Don't we need to prohibit it too?

Alex

On Thu, Nov 11, 2021 at 8:48 PM Jakub Kicinski [off-list ref] wrote:

On Thu, 11 Nov 2021 19:02:40 +0300 Alexander Mikhalitsyn wrote:

quoted

diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
index 5888492a5257..c15e591e5d25 100644
--- a/include/uapi/linux/rtnetlink.h
+++ b/include/uapi/linux/rtnetlink.h

@@ -417,6 +417,9 @@ struct rtnexthop {
 #define RTNH_COMPARE_MASK    (RTNH_F_DEAD | RTNH_F_LINKDOWN | \
                               RTNH_F_OFFLOAD | RTNH_F_TRAP)

+/* these flags can't be set by the userspace */
+#define RTNH_F_REJECT_MASK   (RTNH_F_DEAD | RTNH_F_LINKDOWN)

You should probably drop the _F_ since RTNH_COMPARE_MASK above
does not have it.