Thread (9 messages) flat view 9 messages, 2 authors, 2021-11-02

Re: [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver

From: Matt Johnston <matt@codeconstruct.com.au>
Date: 2021-11-02 06:48:48
Also in: linux-i2c

Hi Randy,
quoted
+config MCTP_TRANSPORT_I2C
+	tristate "MCTP SMBus/I2C transport"
+	# i2c-mux is optional, but we must build as a module if i2c-mux is a module
+	depends on !I2C_MUX || I2C_MUX=y || m
I'm fairly sure that the ending "m" there forces this to always be built
as a loadable module.  Is that what you meant to do here?

Maybe you want something like this?

	depends on I2C_MUX || !I2C_MUX
Checking here it behaves as intended, this gives mctp-i2c built-in:
CONFIG_I2C_MUX=y
CONFIG_MCTP_TRANSPORT_I2C=y

Setting CONFIG_I2C_MUX=m forces CONFIG_MCTP_TRANSPORT_I2C=m. 

Though I will change it to your suggestion since that's more concise.

Cheers,
Matt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help