Thread (9 messages) flat view 9 messages, 2 authors, 2021-11-02

Re: [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver

From: Randy Dunlap <hidden>
Date: 2021-11-01 13:22:44
Also in: linux-i2c

Hi--

On 11/1/21 2:04 AM, Matt Johnston wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/mctp/Kconfig b/drivers/net/mctp/Kconfig
index d8f966cedc89..a468ba7c2f0b 100644
--- a/drivers/net/mctp/Kconfig
+++ b/drivers/net/mctp/Kconfig
@@ -3,6 +3,18 @@ if MCTP
  
  menu "MCTP Device Drivers"
  
+config MCTP_TRANSPORT_I2C
+	tristate "MCTP SMBus/I2C transport"
+	# i2c-mux is optional, but we must build as a module if i2c-mux is a module
+	depends on !I2C_MUX || I2C_MUX=y || m
I'm fairly sure that the ending "m" there forces this to always be built
as a loadable module.  Is that what you meant to do here?

Maybe you want something like this?

	depends on I2C_MUX || !I2C_MUX

That should limit how this driver can be built if I2C_MUX is m.
+	depends on I2C
+	depends on I2C_SLAVE
+	select MCTP_FLOWS
+	help
+	  Provides a driver to access MCTP devices over SMBus/I2C transport,
+	  from DMTF specification DSP0237. A MCTP protocol network device is
+	  created for each I2C bus that has been assigned a mctp-i2c device.

-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help