Re: [PATCH] tcp: md5: Fix overlap between vrf and non-vrf keys
From: David Ahern <hidden>
Date: 2021-10-07 01:14:45
Also in:
lkml
On 10/6/21 11:48 AM, Leonard Crestez wrote:
quoted hunk ↗ jump to hunk
@@ -1103,11 +1116,11 @@ static struct tcp_md5sig_key *tcp_md5_do_lookup_exact(const struct sock *sk, #endif hlist_for_each_entry_rcu(key, &md5sig->head, node, lockdep_sock_is_held(sk)) { if (key->family != family) continue; - if (key->l3index && key->l3index != l3index) + if (key->l3index != l3index)
That seems like the bug fix there. The L3 reference needs to match for new key and existing key. I think the same change is needed in __tcp_md5_do_lookup.
continue; if (!memcmp(&key->addr, addr, size) && key->prefixlen == prefixlen) return key; } base-commit: 9cbfc51af026f5b721a1b36cf622ada591b3c5de