Re: [PATCH] nfc: st95hf: Make spi remove() callback return zero

On 20/10/2021 09:05, Uwe Kleine-König wrote:

Hello Krzysztof,

On Wed, Oct 20, 2021 at 08:55:51AM +0200, Krzysztof Kozlowski wrote:

quoted

On 19/10/2021 22:49, Uwe Kleine-König wrote:

quoted

If something goes wrong in the remove callback, returning an error code
just results in an error message. The device still disappears.

So don't skip disabling the regulator in st95hf_remove() if resetting
the controller via spi fails. Also don't return an error code which just
results in two error messages.

Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/nfc/st95hf/core.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Krzysztof Kozlowski <redacted>

Given you're the listed maintainer for NFC, I wonder who will take this
patch? I expected you to take this patch and not "only" give your
Reviewed-by tag.

Yeah, it's not that obvious. Maybe I should write subsystem/maintainer
guide for NFC...

All NFC patches are taken by netdev folks (David and Jakub) via
patchwork. You did not CC them here, but you CC-ed the netdev, so let's
hope it is enough. You also skipped linux-nfc, so you might need a file:

  $ cat .get_maintainer.conf
  --s

Best regards,
Krzysztof