Thread (6 messages) flat view 6 messages, 3 authors, 2021-10-20

Re: [PATCH] nfc: st95hf: Make spi remove() callback return zero

From: Krzysztof Kozlowski <hidden>
Date: 2021-10-20 06:55:56

On 19/10/2021 22:49, Uwe Kleine-König wrote:
If something goes wrong in the remove callback, returning an error code
just results in an error message. The device still disappears.

So don't skip disabling the regulator in st95hf_remove() if resetting
the controller via spi fails. Also don't return an error code which just
results in two error messages.

Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/nfc/st95hf/core.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Krzysztof Kozlowski <redacted>


Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help