Thread (22 messages) 22 messages, 6 authors, 2021-10-27

Re: [PATCH V4 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-10-15 02:41:56
Also in: linux-s390

On Thu, 14 Oct 2021 15:14:20 +0200 Alexander Lobakin wrote:
quoted
Rx buf len is buffer length of each rx BD. Use ethtool -g command to get
it, and ethtool -G command to set it, examples are as follow:

1. set rx buf len to 4096
$ ethtool -G eth1 rx-buf-len 4096

2. get rx buf len
$ ethtool -g eth1
...
RX Buf Len:     4096  
Isn't that supposed to be changed on changing MTU?
And what if I set Rx buf len value lower than MTU? I see no checks
as well.
Presumably the NIC does scatter.
That means, do we _really_ need two new tunables?
nit let's not say tunable, "tunable" has an API meaning this one
is part of the ring param command.

The question of "why do we need this" seems fair tho - Guangbin,
can you share examples of workloads which benefit from 2k vs 4k?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help