RE: [PATCH V3 net-next 4/6] ethtool: extend ringparam setting uAPI with rx_buf_len
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2021-10-12 14:19:19
Also in:
linux-s390
-----Original Message----- From: Guangbin Huang <redacted> Sent: Tuesday, October 12, 2021 9:41 AM To: davem@davemloft.net; kuba@kernel.org; mkubecek@suse.cz; andrew@lunn.ch; amitc@mellanox.com; idosch@idosch.org; danieller@nvidia.com; jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; jdike@addtoit.com; richard@nod.at; anton.ivanov@cambridgegreys.com; netanel@amazon.com; akiyano@amazon.com; gtzalik@amazon.com; saeedb@amazon.com; chris.snook@gmail.com; ulli.kroll@googlemail.com; linus.walleij@linaro.org; jeroendb@google.com; csully@google.com; awogbemila@google.com; jdmason@kudzu.us; rain.1986.08.12@gmail.com; zyjzyj2000@gmail.com; KY Srinivasan [off-list ref]; Haiyang Zhang [off-list ref]; mst@redhat.com; jasowang@redhat.com; doshir@vmware.com; pv- drivers@vmware.com; jwi@linux.ibm.com; kgraul@linux.ibm.com; hca@linux.ibm.com; gor@linux.ibm.com; johannes@sipsolutions.net Cc: netdev@vger.kernel.org; lipeng321@huawei.com; chenhao288@hisilicon.com; huangguangbin2@huawei.com; linux- s390@vger.kernel.org Subject: [PATCH V3 net-next 4/6] ethtool: extend ringparam setting uAPI with rx_buf_len From: Hao Chen <redacted> Add two new parameters ringparam_ext and extack for .get_ringparam and .set_ringparam to extend more ring params through netlink. Signed-off-by: Hao Chen <redacted> Signed-off-by: Guangbin Huang <redacted> --- arch/um/drivers/vector_kern.c | 4 +++- drivers/net/can/c_can/c_can_ethtool.c | 4 +++- drivers/net/ethernet/3com/typhoon.c | 4 +++- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 8 ++++++-- drivers/net/ethernet/amd/pcnet32.c | 8 ++++++-- drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 8 ++++++-- .../net/ethernet/aquantia/atlantic/aq_ethtool.c | 8 ++++++-- drivers/net/ethernet/atheros/atlx/atl1.c | 8 ++++++-- drivers/net/ethernet/broadcom/b44.c | 8 ++++++-- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 16 ++++++++++++---- drivers/net/ethernet/broadcom/bnx2.c | 8 ++++++-- .../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 8 ++++++-- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 ++++++-- drivers/net/ethernet/broadcom/tg3.c | 10 ++++++++-- drivers/net/ethernet/brocade/bna/bnad_ethtool.c | 8 ++++++-- drivers/net/ethernet/cadence/macb_main.c | 8 ++++++-- .../net/ethernet/cavium/liquidio/lio_ethtool.c | 8 ++++++-- .../net/ethernet/cavium/thunder/nicvf_ethtool.c | 8 ++++++-- drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 8 ++++++-- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 ++++++-- .../net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 8 ++++++-- .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 8 ++++++-- drivers/net/ethernet/cisco/enic/enic_ethtool.c | 8 ++++++-- drivers/net/ethernet/cortina/gemini.c | 8 ++++++-- drivers/net/ethernet/emulex/benet/be_ethtool.c | 4 +++- drivers/net/ethernet/ethoc.c | 8 ++++++-- drivers/net/ethernet/faraday/ftgmac100.c | 8 ++++++-- .../net/ethernet/freescale/enetc/enetc_ethtool.c | 4 +++- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 ++++++-- .../net/ethernet/freescale/ucc_geth_ethtool.c | 8 ++++++-- drivers/net/ethernet/google/gve/gve_ethtool.c | 4 +++- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 6 +++++- .../net/ethernet/hisilicon/hns3/hns3_ethtool.c | 8 ++++++-- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 8 ++++++-- drivers/net/ethernet/ibm/emac/core.c | 4 +++- drivers/net/ethernet/ibm/ibmvnic.c | 8 ++++++-- drivers/net/ethernet/intel/e100.c | 8 ++++++-- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/e1000e/ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 12 ++++++++++-- drivers/net/ethernet/intel/ice/ice_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/igb/igb_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/igbvf/ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/igc/igc_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/ixgb/ixgb_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 8 ++++++-- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 8 ++++++-- drivers/net/ethernet/marvell/mv643xx_eth.c | 8 ++++++-- drivers/net/ethernet/marvell/mvneta.c | 8 ++++++-- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 8 ++++++-- .../marvell/octeontx2/nic/otx2_ethtool.c | 8 ++++++-- drivers/net/ethernet/marvell/skge.c | 8 ++++++-- drivers/net/ethernet/marvell/sky2.c | 8 ++++++-- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 8 ++++++-- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 8 ++++++-- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 8 ++++++-- .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 8 ++++++-- .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c | 4 +++- drivers/net/ethernet/micrel/ksz884x.c | 5 ++++- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 4 +++- drivers/net/ethernet/neterion/s2io.c | 4 +++- .../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 8 ++++++-- drivers/net/ethernet/nvidia/forcedeth.c | 10 ++++++++-- .../ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 10 ++++++++-- drivers/net/ethernet/pasemi/pasemi_mac_ethtool.c | 4 +++- .../net/ethernet/pensando/ionic/ionic_ethtool.c | 8 ++++++-- .../ethernet/qlogic/netxen/netxen_nic_ethtool.c | 8 ++++++-- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 8 ++++++-- .../net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 8 ++++++-- .../net/ethernet/qualcomm/emac/emac-ethtool.c | 8 ++++++-- drivers/net/ethernet/qualcomm/qca_debug.c | 8 ++++++-- drivers/net/ethernet/realtek/8139cp.c | 4 +++- drivers/net/ethernet/realtek/r8169_main.c | 4 +++- drivers/net/ethernet/renesas/ravb_main.c | 8 ++++++-- drivers/net/ethernet/renesas/sh_eth.c | 8 ++++++-- drivers/net/ethernet/sfc/ef100_ethtool.c | 4 +++- drivers/net/ethernet/sfc/ethtool.c | 8 ++++++-- drivers/net/ethernet/sfc/falcon/ethtool.c | 8 ++++++-- .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 8 ++++++-- drivers/net/ethernet/tehuti/tehuti.c | 10 ++++++++-- drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 4 +++- drivers/net/ethernet/ti/cpmac.c | 8 ++++++-- drivers/net/ethernet/ti/cpsw_ethtool.c | 8 ++++++-- drivers/net/ethernet/ti/cpsw_priv.h | 8 ++++++-- .../net/ethernet/toshiba/spider_net_ethtool.c | 4 +++- drivers/net/ethernet/xilinx/ll_temac_main.c | 14 ++++++++++---- .../net/ethernet/xilinx/xilinx_axienet_main.c | 14 ++++++++++---- drivers/net/hyperv/netvsc_drv.c | 8 ++++++-- drivers/net/netdevsim/ethtool.c | 8 ++++++-- drivers/net/usb/r8152.c | 8 ++++++-- drivers/net/virtio_net.c | 4 +++- drivers/net/vmxnet3/vmxnet3_ethtool.c | 8 ++++++-- drivers/s390/net/qeth_ethtool.c | 4 +++- include/linux/ethtool.h | 8 ++++++-- net/ethtool/ioctl.c | 9 ++++++--- net/ethtool/rings.c | 15 +++++++++++---- net/mac80211/ethtool.c | 8 ++++++-- 99 files changed, 568 insertions(+), 187 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/hyperv/netvsc_drv.cb/drivers/net/hyperv/netvsc_drv.c index 382bebc2420d..1a68301a9444 100644--- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c@@ -1857,7 +1857,9 @@ static void __netvsc_get_ringparam(structnetvsc_device *nvdev, } static void netvsc_get_ringparam(struct net_device *ndev, - struct ethtool_ringparam *ring) + struct ethtool_ringparam *ring, + struct ethtool_ringparam_ext *ring_ext, + struct netlink_ext_ack *extack) { struct net_device_context *ndevctx = netdev_priv(ndev); struct netvsc_device *nvdev = rtnl_dereference(ndevctx->nvdev);@@ -1869,7 +1871,9 @@ static void netvsc_get_ringparam(struct net_device*ndev, } static int netvsc_set_ringparam(struct net_device *ndev, - struct ethtool_ringparam *ring) + struct ethtool_ringparam *ring, + struct ethtool_ringparam_ext *ring_ext, + struct netlink_ext_ack *extack) { struct net_device_context *ndevctx = netdev_priv(ndev); struct netvsc_device *nvdev = rtnl_dereference(ndevctx->nvdev);
The changes to netvsc_drv.c look good. Thanks. Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>