Re: [PATCH v2 2/2] net: macb: Allow SGMII only if we are a GEM in mac_validate

Hello Sean,

Quoting Jakub Kicinski (2021-10-12 02:17:59)

On Mon, 11 Oct 2021 12:55:17 -0400 Sean Anderson wrote:

quoted

This aligns mac_validate with mac_config. In mac_config, SGMII is only
enabled if macb_is_gem. Validate should care if the mac is a gem as
well. This also simplifies the logic now that all gigabit modes depend
on the mac being a GEM.

This looks correct.

quoted

Fixes: 7897b071ac3b ("net: macb: convert to phylink")

If this is a fix, the patch has to be first in the series as it is
depending on the first one which is not a fix.

Thanks,
Antoine