Re: [net-next PATCH 2/3] octeontx2-pf: Add devlink param to vary cqe size

On Fri, 8 Oct 2021 12:42:34 +0530 sundeep subbaraya wrote:

On Wed, Oct 6, 2021 at 7:10 PM Jakub Kicinski [off-list ref] wrote:

quoted

On Wed, 6 Oct 2021 12:29:51 +0530 sundeep subbaraya wrote:  

quoted

We do use ethtool -G for setting the number of receive buffers to
allocate from the kernel and give those pointers to hardware memory pool(NPA).  

You can extend the ethtool API.  

I will rework on this patch. Is it okay I drop this patch in this
series and send only patches 1 and 3 for v3?

The first patch looks fine. But the last is where I think a common
interface is most likely to succeed, so no, patch 3 is not fine. 

The documentation (which BTW is required for devlink params) is lacking
so I can't be sure but patch 3 looks similar to what Huawei has been
working on, take a look:

https://lore.kernel.org/all/20210924142959.7798-4-huangguangbin2@huawei.com/ (local)