Thread (10 messages) flat view 10 messages, 3 authors, 2021-10-08

Re: [net-next PATCH 1/3] octeontx2-pf: Simplify the receive buffer size calculation

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-10-06 01:11:51

On Tue, 5 Oct 2021 22:45:34 +0530 Subbaraya Sundeep wrote:
This patch separates the logic of configuring hardware
maximum transmit frame size and receive frame size.
This simplifies the logic to calculate receive buffer
size and using cqe descriptor of different size.
Also additional size of skb_shared_info structure is
allocated for each receive buffer pointer given to
hardware which is not necessary. Hence change the
size calculation to remove the size of
skb_shared_info. Add a check for array out of
bounds while adding fragments to the network stack.
drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c:91:54: error: ‘struct otx2_nic’ has no member named ‘max_frs’
   91 |  aq->sq.smq_rr_weight = mtu_to_dwrr_weight(pfvf, pfvf->max_frs);
      |                                                      ^~
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help