Re: [PATCH net-next 2/3] eth: platform: add a helper for loading netdev->dev_addr

On Thu, 7 Oct 2021 16:10:27 +0200 Andrew Lunn wrote:

On Thu, Oct 07, 2021 at 06:57:01AM -0700, Jakub Kicinski wrote:

quoted

quoted

this eventually calls ether_addr_copy(), which has a note:
   Please note: dst & src must both be aligned to u16.

Is this true for this addr on the stack?  

It will but I don't think there's anything in the standard that
requires it. Let me slap __aligned(2) on it to be sure.  

Hi Jakub

I though you changed ether_addr_copy() to be a memcpy?
Or was that some other helper?

I changed eth_hw_addr_set(), I think Michael is referring to 
a ether_addr_copy() inside eth_platform_get_mac_address().