Re: [PATCH net-next 2/3] eth: platform: add a helper for loading netdev->dev_addr
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-10-07 13:57:05
On Thu, 07 Oct 2021 15:42:17 +0200 Michael Walle wrote:
quoted
+int platform_get_ethdev_address(struct device *dev, struct net_device *netdev) +{ + u8 addr[ETH_ALEN]; + int ret; + + ret = eth_platform_get_mac_address(dev, addr);this eventually calls ether_addr_copy(), which has a note: Please note: dst & src must both be aligned to u16. Is this true for this addr on the stack?
It will but I don't think there's anything in the standard that requires it. Let me slap __aligned(2) on it to be sure.