Re: [PATCH net-next 0/4] mlx4: prep for constant dev->dev_addr

On 10/4/2021 10:14 PM, Jakub Kicinski wrote:

This patch converts mlx4 for dev->dev_addr being const. It converts
to use of common helpers but also removes some seemingly unnecessary
idiosyncrasies.

Please review.

Thanks for your series.
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

Jakub Kicinski (4):
   mlx4: replace mlx4_mac_to_u64() with ether_addr_to_u64()
   mlx4: replace mlx4_u64_to_mac() with u64_to_ether_addr()
   mlx4: remove custom dev_addr clearing
   mlx4: constify args for const dev_addr

  drivers/infiniband/hw/mlx4/main.c             |  2 +-
  drivers/infiniband/hw/mlx4/qp.c               |  2 +-
  drivers/net/ethernet/mellanox/mlx4/cmd.c      |  4 +-
  .../net/ethernet/mellanox/mlx4/en_netdev.c    | 37 +++++++------------
  drivers/net/ethernet/mellanox/mlx4/fw.c       |  2 +-
  drivers/net/ethernet/mellanox/mlx4/mcg.c      |  2 +-
  include/linux/mlx4/device.h                   |  2 +-
  include/linux/mlx4/driver.h                   | 22 -----------
  8 files changed, 21 insertions(+), 52 deletions(-)