Re: [PATCH net-next 3/4] mlx4: remove custom dev_addr clearing
From: Tariq Toukan <hidden>
Date: 2021-10-05 10:21:40
Also in:
linux-rdma
On 10/4/2021 10:14 PM, Jakub Kicinski wrote:
mlx4_en_u64_to_mac() takes the dev->dev_addr pointer and writes to it byte by byte. It also clears the two bytes _after_ ETH_ALEN which seems unnecessary. dev->addr_len is set to ETH_ALEN just before the call. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>