Re: [PATCH net v2 1/2] ptp: idt82p33: optimize idt82p33_adjtime
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-09-17 19:58:35
Also in:
lkml
On Fri, Sep 17, 2021 at 10:39:48AM -0400, min.li.xe@renesas.com wrote:
quoted hunk ↗ jump to hunk
From: Min Li <redacted> The current adjtime implementation is read-modify-write and immediately triggered, which is not accurate due to slow i2c bus access. Therefore, we will use internally generated 1 PPS pulse as trigger, which will improve adjtime accuracy significantly. On the other hand, the new trigger will not change TOD immediately but delay it to the next 1 PPS pulse. Signed-off-by: Min Li <redacted> --- drivers/ptp/ptp_idt82p33.c | 221 ++++++++++++++++++++++++++++++--------------- drivers/ptp/ptp_idt82p33.h | 28 +++--- 2 files changed, 165 insertions(+), 84 deletions(-)diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c index c1c959f..abe628c 100644 --- a/drivers/ptp/ptp_idt82p33.c +++ b/drivers/ptp/ptp_idt82p33.c@@ -24,15 +24,10 @@ MODULE_LICENSE("GPL"); MODULE_FIRMWARE(FW_FILENAME); /* Module Parameters */ -static u32 sync_tod_timeout = SYNC_TOD_TIMEOUT_SEC; -module_param(sync_tod_timeout, uint, 0); -MODULE_PARM_DESC(sync_tod_timeout, -"duration in second to keep SYNC_TOD on (set to 0 to keep it always on)"); -
Despite module parameters not being liked, they are probably also considered ABI. So you probably cannot remove it. Andrew