Re: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-17 19:54:06
Also in:
lkml
On Fri, 17 Sep 2021 10:39:49 -0400 min.li.xe@renesas.com wrote:
From: Min Li <redacted> Current adjtime is not accurate when delta is smaller than 10000ns. So for small time correction, we will switch to DCO mode to pull phase more precisely in one second duration. Signed-off-by: Min Li <redacted>
Please fix the checkpatch issues.
quoted hunk ↗ jump to hunk
@@ -29,6 +29,14 @@ module_param(phase_snap_threshold, uint, 0); MODULE_PARM_DESC(phase_snap_threshold, "threshold (1000ns by default) below which adjtime would ignore"); +static bool delayed_accurate_adjtime = false; +module_param(delayed_accurate_adjtime, bool, false); +MODULE_PARM_DESC(delayed_accurate_adjtime, +"set to true to use more accurate adjtime that is delayed to next 1PPS signal");
Module parameters are discouraged. If you have multiple devices on the system module parameters don't allow setting different options depending on device. Unless Richard or someone else suggests a better API for this please use something like devlink params instead (and remember to document them).
+static char *firmware; +module_param(firmware, charp, 0);
What's the point of this? Just rename the file in the filesystem.