Re: [PATCH v1 net] net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2021-09-16 11:39:23
Also in:
lkml
On Wed, Sep 15, 2021 at 06:23:40PM -0700, Colin Foster wrote:
When updating ocelot to use phylink, a second write to DEV_CLOCK_CFG was
mistakenly left in. It used the variable "speed" which, previously, would
would have been assigned a value of OCELOT_SPEED_1000. In phylink the
variable is be SPEED_1000, which is invalid for the
DEV_CLOCK_LINK_SPEED macro. Removing it as unnecessary and buggy.
Fixes: e6e12df625f2 ("net: mscc: ocelot: convert to phylink")
Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
---Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>