Re: [PATCH net-next v2] net: phy: at803x: add support for qca 8327 internal phy
From: DENG Qingfang <dqfext@gmail.com>
Date: 2021-09-15 07:27:48
Also in:
lkml
On Tue, Sep 14, 2021 at 02:33:45PM +0200, Ansuel Smith wrote:
+}, {
+ /* QCA8327 */
+ .phy_id = QCA8327_PHY_ID,
+ .phy_id_mask = QCA8K_PHY_ID_MASK,
+ .name = "QCA PHY 8327",
+ /* PHY_GBIT_FEATURES */
+ .probe = at803x_probe,
+ .flags = PHY_IS_INTERNAL,
+ .config_init = qca83xx_config_init,
+ .soft_reset = genphy_soft_reset,How about setting .suspend and .resume? Without these, the PHY cannot be powered down/up administratively (via ip link set xxx down/up). See commit 93100d6817b0. Off-topic: When is .soft_reset called? The MediaTek PHY driver seems to work fine without it.
+ .get_sset_count = at803x_get_sset_count, + .get_strings = at803x_get_strings, + .get_stats = at803x_get_stats, }, };