Re: [PATCH net-next 6/6 v6] net: dsa: rtl8366: Drop and depromote pointless prints

On Sat, Sep 25, 2021 at 8:56 PM Vladimir Oltean [off-list ref] wrote:

quoted

-     dev_info(smi->dev, "add VLAN %d on port %d, %s, %s\n",
-              vlan->vid, port, untagged ? "untagged" : "tagged",
-              pvid ? " PVID" : "no PVID");
-
-     if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
-             dev_err(smi->dev, "port is DSA or CPU port\n");
+     dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
+             vlan->vid, port, untagged ? "untagged" : "tagged",
+             pvid ? " PVID" : "no PVID");

This is better, not going to complain too much, but I mean,
rtl8366_set_vlan and rtl8366_set_pvid already have debugging prints in
them, how can you tolerate so many superfluous prints, what do they
bring useful?

I actually use them ... I suppose one can use ftrace instead
and/or gdb, but I'm one of those die hard printk() debuggers
and I like to follow what happens like that.

When the driver gets mature we can delete most  or all of the
dev_dbg() messages I think.

Yours,
Linus Walleij