Re: [PATCH net-next 5/6 v6] net: dsa: rtl8366: Fix a bug in deleting VLANs
flat view
From: Alvin Šipraga <hidden>
Date: 2021-09-25 17:18:14
On 9/25/21 3:23 PM, Linus Walleij wrote:
We were checking that the MC (member config) was != 0
Minor nitpick: actually we were checking the untag mask != 0, right? The change itself seems fine though: Reviewed-by: Alvin Šipraga <redacted>
quoted hunk ↗ jump to hunk
for some reason, all we need to check is that the config has no ports, i.e. no members. Then it can be recycled. This must be some misunderstanding. Fixes: 4ddcaf1ebb5e ("net: dsa: rtl8366: Properly clear member config") Cc: Vladimir Oltean <olteanv@gmail.com> Cc: Mauri Sandberg <redacted> Cc: Alvin Šipraga <redacted> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: DENG Qingfang <dqfext@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Linus Walleij <redacted> --- ChangeLog v5->v6: - No changes just resending with the rest of the patches. ChangeLog v4->v5: - Collect Florians review tag - Add Fixes tag ChangeLog v1->v4: - New patch for a bug found while fixing the other issues. --- drivers/net/dsa/rtl8366.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c index 0672dd56c698..f815cd16ad48 100644 --- a/drivers/net/dsa/rtl8366.c +++ b/drivers/net/dsa/rtl8366.c@@ -374,7 +374,7 @@ int rtl8366_vlan_del(struct dsa_switch *ds, int port, * anymore then clear the whole member * config so it can be reused. */ - if (!vlanmc.member && vlanmc.untag) { + if (!vlanmc.member) { vlanmc.vid = 0; vlanmc.priority = 0; vlanmc.fid = 0;