Thread (12 messages) 12 messages, 5 authors, 2021-10-25

Re: [PATCH net v2] napi: fix race inside napi_enable

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-23 13:14:24

On Wed, 22 Sep 2021 14:47:47 +0800 Xuan Zhuo wrote:
quoted
Why don't you just invert the order of clearing the bits:  
I think it should be an atomic operation. The original two-step clear itself is
problematic. So from this perspective, it is not just a solution to this
problem.
[resending, my MUA seems to have corrupted the CC list previously]

Can you show what breaks by it being non-atomic?

Because, again, the disable part is not atomic. Either it's needed on
both sides or it's not needed on either.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help