Re: [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()"

On Fri, 2021-09-17 at 09:41 -0700, Eric Dumazet wrote:

On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni [off-list ref] wrote:

quoted

This is a partial revert for commit b796d04bd014 ("tcp:
factor out tcp_build_frag()").

MPTCP was the only user of the tcp_build_frag helper, and after
the previous patch MPTCP does not use the mentioned helper anymore.
Let's avoid exposing TCP internals.

The revert is partial, as tcp_remove_empty_skb(), exposed
by the same commit is still required.

I would simply remove the extern in include, and make this nice helper static ?

This would avoid code churn, and keep a clean code.

I thought you would have preferred otherwise. I'll make the helper
static in the next iteration.

Thanks!

Paolo