Re: [PATCH net-next 8/8] net: dsa: rtl8366: Drop and depromote pointless prints
flat view
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-09-13 17:36:01
On 9/13/2021 7:43 AM, Linus Walleij wrote:
We don't need a message for every VLAN association, dbg is fine. The message about adding the DSA or CPU port to a VLAN is directly misleading, this is perfectly fine. Cc: Vladimir Oltean <olteanv@gmail.com> Cc: Mauri Sandberg <redacted> Cc: Alvin Šipraga <redacted> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: DENG Qingfang <dqfext@gmail.com> Signed-off-by: Linus Walleij <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Maybe at some point we should think about moving that kind of debugging messages towards the DSA core, and just leave drivers with debug prints that track an internal state not visible to the DSA framework. -- Florian