Re: [PATCH] net: fix tp->undo_retrans accounting in tcp_sacktag_one()

On Thu, Sep 9, 2021 at 9:38 AM Neal Cardwell [off-list ref] wrote:

On Thu, Sep 9, 2021 at 6:34 AM zhenggy [off-list ref] wrote:

quoted

Commit a71d77e6be1e ("tcp: fix segment accounting when DSACK range covers
multiple segments") fix some DSACK accounting for multiple segments.
In tcp_sacktag_one(), we should also use the actual DSACK rang(pcount)
for tp->undo_retrans accounting.

Signed-off-by: zhenggy <redacted>

Another nit: in the commit title, rather than "net":

  net: fix tp->undo_retrans accounting in tcp_sacktag_one()

...I would suggest the more specific "tcp", which is more typical for
commits fixing tcp*.c files:

  tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()

thanks,
neal