Re: [PATCH net-next v3 2/9] ravb: Add struct ravb_hw_info to driver data
From: Sergey Shtylyov <hidden>
Date: 2021-08-19 16:19:26
Also in:
linux-renesas-soc
On 8/18/21 10:07 PM, Biju Das wrote:
The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are similar to the R-Car Ethernet AVB IP. With a few changes in the driver we can support both IPs. This patch adds the struct ravb_hw_info to hold hw features, driver data and function pointers to support both the IPs. It also replaces the driver data chip type with struct ravb_hw_info by moving chip type to it. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- v2->v3: * Retained Rb tag from Andrew, since there is no functionality change apart from just splitting the patch into 2. Also updated the commit description. v2: * Incorporated Andrew and Sergei's review comments for making it smaller patch and provided detailed description.
[...]
quoted hunk ↗ jump to hunk
static inline u32 ravb_read(struct net_device *ndev, enum ravb_reg reg)diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 94eb9136752d..b6554e5e13af 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c
[...]
quoted hunk ↗ jump to hunk
@@ -2113,7 +2122,7 @@ static int ravb_probe(struct platform_device *pdev) } } - priv->chip_id = chip_id; + priv->chip_id = info->chip_id;
Do we still need priv->chip_id?
priv->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(priv->clk)) {[...] Reviewed-by: Sergey Shtylyov <redacted> [...] MBR, Sergey