Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH

On Mon, Aug 23, 2021 at 10:52 PM Joel Stanley [off-list ref] wrote:

On Mon, 23 Aug 2021 at 18:44, Rob Herring [off-list ref] wrote:

quoted

On Fri, Aug 20, 2021 at 05:17:25PM +0930, Joel Stanley wrote:

quoted

quoted

+
+  interrupts:
+    maxItems: 1
+

quoted

+  rx-fifo-depth: true
+  tx-fifo-depth: true

Needs a vendor prefix, type, description and constraints.

These are the standard properties from the ethernet-controller.yaml. I
switched the driver to using those once I discovered they existed (v1
defined these in terms of slots, whereas the ethernet-controller
bindings use bytes).

Indeed (grepping the wrong repo didn't work too well :) ).

Still, I'd assume there's some valid range for this h/w you can
define? Or 0 - 2^32 is valid?

Rob