Re: [PATCH v4 2/3] can: rcar_canfd: Add support for RZ/G2L family
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-08-10 08:27:11
Also in:
linux-can, linux-devicetree, linux-renesas-soc, lkml
Hi Prabhakar, On Tue, Jul 27, 2021 at 3:30 PM Lad Prabhakar [off-list ref] wrote:
CANFD block on RZ/G2L SoC is almost identical to one found on R-Car Gen3 SoC's. On RZ/G2L SoC interrupt sources for each channel are split into different sources and the IP doesn't divide (1/2) CANFD clock within the IP. This patch adds compatible string for RZ/G2L family and splits the irq handlers to accommodate both RZ/G2L and R-Car Gen3 SoC's. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks for your patch! I've just noticed a set of silly typos:
quoted hunk ↗ jump to hunk
--- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c
+static void rcar_canfd_handle_global_recieve(struct rcar_canfd_global *gpriv, u32 ch)
receive (everywhere)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds