RE: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies

-----Original Message-----
From: Arnd Bergmann <arnd@kernel.org>
Sent: Monday, August 02, 2021 1:59 PM
To: Keller, Jacob E <jacob.e.keller@intel.com>
Cc: Richard Cochran <richardcochran@gmail.com>; Nicolas Pitre
[off-list ref]; Brandeburg, Jesse [off-list ref];
Nguyen, Anthony L [off-list ref]; David S. Miller
[off-list ref]; Jakub Kicinski [off-list ref]; Arnd Bergmann
[off-list ref]; Kurt Kanzenbach [off-list ref]; Saleem, Shiraz
[off-list ref]; Ertman, David M [off-list ref];
intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
dependencies

On Mon, Aug 2, 2021 at 10:46 PM Keller, Jacob E
[off-list ref] wrote:

quoted

quoted

You can do something like it for a particular symbol though, such as

config MAY_USE_PTP_1588_CLOCK
       def_tristate PTP_1588_CLOCK || !PTP_1588_CLOCK

 config E1000E
        tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
        depends on PCI && (!SPARC32 || BROKEN)
+       depends on MAY_USE_PTP_1588_CLOCK
        select CRC32
-       imply PTP_1588_CLOCK

What about "integrates"?

Maybe, we'd need to look at whether that fits for the other users of the
"A || !A" trick.

Sure.  I just know from reading it other places it really causes a "huh?" reaction.