Thread (23 messages) flat view 23 messages, 5 authors, 2021-08-04

RE: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies

From: "Keller, Jacob E" <jacob.e.keller@intel.com>
Date: 2021-08-02 21:09:30
Also in: intel-wired-lan, lkml

-----Original Message-----
From: Arnd Bergmann <arnd@kernel.org>
Sent: Monday, August 02, 2021 1:59 PM
To: Keller, Jacob E <jacob.e.keller@intel.com>
Cc: Richard Cochran <richardcochran@gmail.com>; Nicolas Pitre
[off-list ref]; Brandeburg, Jesse [off-list ref];
Nguyen, Anthony L [off-list ref]; David S. Miller
[off-list ref]; Jakub Kicinski [off-list ref]; Arnd Bergmann
[off-list ref]; Kurt Kanzenbach [off-list ref]; Saleem, Shiraz
[off-list ref]; Ertman, David M [off-list ref];
intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
dependencies

I don't want to mess with the semantics of the keyword any further.
The original meaning was meant to avoid circular dependencies
by making it a softer version of 'select' that would not try to select
anything that has unmet dependencies. The current version made
it even softer by only having an effect during 'make defconfig'
and 'make oldconfig' but not preventing it from being soft-disabled
any more. Changing it yet again is guarantee to break lots of the
existing users, while probably also bringing back the original problem
of the circular dependencies.

         Arnd
Yea ok that makes sense. Better to use a new keyword if we do at all.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help