Re: [PATCH iproute2-next 01/17] ip: bridge: add support for mcast_vlan_snooping

On 26/08/2021 18:08, Stephen Hemminger wrote:

On Thu, 26 Aug 2021 16:05:17 +0300
Nikolay Aleksandrov [off-list ref] wrote:

quoted

+		} else if (matches(*argv, "mcast_vlan_snooping") == 0) {
+			__u32 mcvl_bit = 1 << BR_BOOLOPT_MCAST_VLAN_SNOOPING;

Using matches() is problematic.  since it will change how 'mcast' is
handled.

Overall, bridge command (and rest of iproute2) needs to move
away from matches

Sure, I can send a follow up if you don't mind to switch all matches calls. I used it
to be in line with the current code.