Thread (26 messages) flat view 26 messages, 5 authors, 2021-08-31

Re: [PATCH iproute2-next 01/17] ip: bridge: add support for mcast_vlan_snooping

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2021-08-26 15:08:56

On Thu, 26 Aug 2021 16:05:17 +0300
Nikolay Aleksandrov [off-list ref] wrote:
+		} else if (matches(*argv, "mcast_vlan_snooping") == 0) {
+			__u32 mcvl_bit = 1 << BR_BOOLOPT_MCAST_VLAN_SNOOPING;
Using matches() is problematic.  since it will change how 'mcast' is
handled.

Overall, bridge command (and rest of iproute2) needs to move
away from matches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help