Re: [RFC PATCH net-next v2 1/6] ethtool: Add ability to control transceiver modules' power mode

On Thu, Aug 19, 2021 at 03:13:10PM +0200, Andrew Lunn wrote:

quoted

quoted

Should we also document what the default is? Seems like
ETHTOOL_MODULE_POWER_MODE_POLICY_HIGH_ON_UP is the generic network
interface default, so maybe it should also be the default for SFPs?

I will add a note in Documentation/networking/ethtool-netlink.rst that
the default power mode policy is driver-dependent (can be queried) and
that it can either be 'high' or 'auto'.

Hi Ido

Hi Andrew,

That is kind of my question. Do you want the default driver defined,
and varying between implementations, or do we want a clearly defined
default?

The stack has a mixture of both. An interface is admin down by
default, but it is anybody guess how pause will be configured?

By making it driver undefined, you cannot assume anything, and you
require user space to always configure it.

I don't have too strong an opinion, i'm more interested in what others
say, those who have to live with this.

I evaluated the link up times using a QSFP module [1] connected to my
system. There is a 36% increase in link up times when using the 'auto'
policy compared to the 'high' policy (default on all Mellanox systems).
Very noticeable and very measurable.

Couple the above with the fact that despite shipping millions of ports
over the years, we are only now getting requests to control the power
mode of transceivers and from a small number of users.

In addition, any user space that is interested in changing the behavior,
has the ability to query the default policy and override it in a
vendor-agnostic way.

Therefore, I'm strictly against changing the existing behavior.

[1] https://www.mellanox.com/related-docs/prod_cables/PB_MFS1S00-VxxxE_200GbE_QSFP56_AOC.pdf

	Andrew