Re: [PATCH] net/mlx5e: Make use of pr_warn()

On Mon, 2021-08-09 at 13:24 +0300, Leon Romanovsky wrote:

On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:

[...]

quoted

-                       printk(KERN_WARNING "mlx5: can't set and
add to the same HW field (%x)\n", f->field);
+                       pr_warn("mlx5: can't set and add to the
same HW field (%x)\n", f->field);

It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.

please use: netdev_warn(priv->netdev,

quoted

                        return -EOPNOTSUPP;
                }
 

@@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct

mlx5e_priv *priv,
                if (first < next_z && next_z < last) {
                        NL_SET_ERR_MSG_MOD(extack,
                                           "rewrite of few sub-
fields isn't supported");
-                       printk(KERN_WARNING "mlx5: rewrite of few
sub-fields (mask %lx) isn't offloaded\n",
-                              mask);
+                       pr_warn("mlx5: rewrite of few sub-fields
(mask %lx) isn't offloaded\n",
+                               mask);

ditto

same