Re: [PATCH] net/mlx5e: Make use of pr_warn()
From: Leon Romanovsky <leon@kernel.org>
Date: 2021-08-09 10:24:47
Also in:
linux-rdma
On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:
quoted hunk ↗ jump to hunk
to replace printk(KERN_WARNING ...) with pr_warn() kindly Signed-off-by: Cai Huoqing <redacted> --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index e5c4344a114e..ab7c059e630f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c@@ -2702,7 +2702,7 @@ static int offload_pedit_fields(struct mlx5e_priv *priv, if (s_mask && a_mask) { NL_SET_ERR_MSG_MOD(extack, "can't set and add to the same HW field"); - printk(KERN_WARNING "mlx5: can't set and add to the same HW field (%x)\n", f->field); + pr_warn("mlx5: can't set and add to the same HW field (%x)\n", f->field);
It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.
quoted hunk ↗ jump to hunk
return -EOPNOTSUPP; }@@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct mlx5e_priv *priv, if (first < next_z && next_z < last) { NL_SET_ERR_MSG_MOD(extack, "rewrite of few sub-fields isn't supported"); - printk(KERN_WARNING "mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n", - mask); + pr_warn("mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n", + mask);
ditto Thanks
return -EOPNOTSUPP; } -- 2.25.1